smengcl commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure. URL: https://github.com/apache/hadoop/pull/1673#issuecomment-545995357 Thanks @jojochuang for pinging. Thanks @tasanuma for the patch. I tested this locally. Those scripts correctly points to the jars now: ```bash $ mvn install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true $ cd hadoop-dist/target/hadoop-3.3.0-SNAPSHOT $ ./share/hadoop/tools/dynamometer/dynamometer-blockgen/bin/generate-block-lists.sh Exception in thread "main" org.apache.commons.cli.MissingOptionException: Missing required options: fsimage_input_path, block_image_output_dir, num_datanodes ... $ ./share/hadoop/tools/dynamometer/dynamometer-infra/bin/start-dynamometer-cluster.sh 2019-10-24 09:16:16,098 INFO dynamometer.Client: Initializing Client 2019-10-24 09:16:16,099 ERROR dynamometer.Client: Error running Client org.apache.commons.cli.MissingOptionException: Missing required option: ... $ ./share/hadoop/tools/dynamometer/dynamometer-workload/bin/start-workload.sh Exception in thread "main" org.apache.commons.cli.MissingOptionException: Missing required options: nn_uri, mapper_class_name ... ``` Before the patch is was complaining: ```bash $ ./share/hadoop/tools/dynamometer/dynamometer-blockgen/bin/generate-block-lists.sh JAR does not exist or is not a normal file: /Users/smeng/repo/trunk/hadoop-dist/target/hadoop-3.3.0-SNAPSHOT/share/hadoop/tools/dynamometer/dynamometer-blockgen/lib/dynamometer-blockgen-*.jar ``` LGTM +1
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
