jlowe commented on a change in pull request #1618: MAPREDUCE-7240.Exception
'Invalid event: TA_TOO_MANY_FETCH_FAILURE at…
URL: https://github.com/apache/hadoop/pull/1618#discussion_r339538543
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
##########
@@ -377,6 +377,12 @@
TaskAttemptEventType.TA_COMMIT_PENDING,
TaskAttemptEventType.TA_FAILMSG,
TaskAttemptEventType.TA_FAILMSG_BY_CLIENT))
+ // Transitions from SUCCESS_FINISHING_CONTAINER state to FAILED stat
+ // When the event TA_TOO_MANY_FETCH_FAILURE received
Review comment:
Nit: IMO this comment isn't worth it since it exactly parrots the code.
Also I'd prefer to see this transition appear before the ignored transitions in
this state, as the convention has been to put ignored transitions at the end of
the list of event handlers for each state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
