steveloughran commented on a change in pull request #1655: HADOOP-16629: 
support copyFile in s3afilesystem
URL: https://github.com/apache/hadoop/pull/1655#discussion_r339671178
 
 

 ##########
 File path: 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
 ##########
 @@ -3193,6 +3266,30 @@ public String getCanonicalServiceName() {
   private CopyResult copyFile(String srcKey, String dstKey, long size,
       S3ObjectAttributes srcAttributes, S3AReadOpContext readContext)
       throws IOException, InterruptedIOException  {
+    return copyFile(bucket, srcKey, bucket, dstKey, size, srcAttributes, 
readContext);
 
 Review comment:
   this doesn't update S3Guard BTW. IF you want newly created files to be 
visible, your copy operation owns this problem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to