steveloughran commented on a change in pull request #1611: HADOOP-16612 Track
Azure Blob File System client-perceived latency
URL: https://github.com/apache/hadoop/pull/1611#discussion_r341273323
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -289,10 +289,13 @@ private synchronized void writeCurrentBufferToService()
throws IOException {
final Future<Void> job = completionService.submit(new Callable<Void>() {
@Override
public Void call() throws Exception {
- client.append(path, offset, bytes, 0,
- bytesLength);
- byteBufferPool.putBuffer(ByteBuffer.wrap(bytes));
- return null;
+ try (AbfsPerfInfo tracker = new
AbfsPerfInfo(client.getAbfsPerfTracker(), "writeCurrentBufferToService",
"append")) {
Review comment:
the abfs code hasn't been that strict about 80 chars, but it is nice to have
a length which makes it easy for side-by-side diff reviews. Here I'd put a
newline after the = sign
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
