jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure
Blob File System client-perceived latency
URL: https://github.com/apache/hadoop/pull/1611#discussion_r342349006
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -785,14 +785,15 @@ public void setOwner(final Path path, final String
owner, final String group) th
"This operation is only valid for storage accounts with the
hierarchical namespace enabled.");
}
- LOG.debug(
- "setOwner filesystem: {} path: {} owner: {} group: {}",
- client.getFileSystem(),
- path.toString(),
- owner,
- group);
-
try (AbfsPerfInfo perfInfo = startTracking("setOwner", "setOwner")) {
+
+ LOG.debug(
Review comment:
@goiri For the sake of consistency and of being objective, we should
consider each member method here as a black box. Wrapping the contents of each
method inside the instrumentation tracker is the overall objective here. This
essentially helps us get a picture that is closer to what the users of the ABFS
driver will see.
On the request of @DadanielZ, the lines for the check of
getIsNamespaceEnabled() is outside of this wrapper but we should treat that as
an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
