[ 
https://issues.apache.org/jira/browse/HADOOP-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970447#comment-16970447
 ] 

Steve Loughran commented on HADOOP-16181:
-----------------------------------------

This is too noisy: we don't need to know when shutdowns work.

Currently shutting down an s3a FS instance generates 4 lines of info
{code}
2019-11-08 17:33:20,379 [main] INFO  s3guard.S3GuardTool 
(S3GuardTool.java:run(1763)) - Audit scanned 1 directories
2019-11-08 17:33:20,381 [shutdown-hook-0] DEBUG s3a.S3AFileSystem 
(S3AFileSystem.java:close(3117)) - Filesystem s3a://hwdev-steve-ireland-new is 
closed
2019-11-08 17:33:20,384 [shutdown-hook-0] INFO  s3a.S3AFileSystem 
(HadoopExecutors.java:shutdown(118)) - Gracefully shutting down executor 
service. Waiting max 30 SECONDS
2019-11-08 17:33:20,384 [shutdown-hook-0] INFO  s3a.S3AFileSystem 
(HadoopExecutors.java:shutdown(129)) - Succesfully shutdown executor service
2019-11-08 17:33:20,384 [shutdown-hook-0] INFO  s3a.S3AFileSystem 
(HadoopExecutors.java:shutdown(118)) - Gracefully shutting down executor 
service. Waiting max 30 SECONDS
2019-11-08 17:33:20,384 [shutdown-hook-0] INFO  s3a.S3AFileSystem 
(HadoopExecutors.java:shutdown(129)) - Succesfully shutdown executor service
{code}

Could you do a followup which logs @ debug

> HadoopExecutors shutdown Cleanup
> --------------------------------
>
>                 Key: HADOOP-16181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16181
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>             Fix For: 3.2.1
>
>         Attachments: HADOOP-16181.1.patch, HADOOP-16181.2.patch
>
>
> # Add method description
> # Add additional logging
> # Do not log-and-throw Exception.  Anti-pattern.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to