[
https://issues.apache.org/jira/browse/HADOOP-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971547#comment-16971547
]
Steve Loughran commented on HADOOP-16694:
-----------------------------------------
> if it's also reasonable to replace instances of Preconditions.checkNotNull
> with Objects.requireNotNull to reduce our exposure to Guava a bit? But I
> guess the shading work makes that a less necessary endeavor.
That makes for a way bigger patch and more expensive cherry picking/ back
porting. We could say: switch to requireNonNull in future, but I'm reluctant to
go for every Preconditions check, especially as we have a lot of checkState
calls to... It's not like we can get rid of guava.
> Use Objects requireNonNull Where Appropriate
> --------------------------------------------
>
> Key: HADOOP-16694
> URL: https://issues.apache.org/jira/browse/HADOOP-16694
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.2
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HADOOP-16694.1.patch, HADOOP-16694.2.patch,
> HADOOP-16694.3.patch
>
>
> https://docs.oracle.com/javase/8/docs/api/java/util/Objects.html#requireNonNull-T-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
