steveloughran commented on a change in pull request #1702: HDFS-14788 Use
dynamic regex filter to ignore copy of source files in…
URL: https://github.com/apache/hadoop/pull/1702#discussion_r345747544
##########
File path:
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyFilter.java
##########
@@ -47,13 +53,29 @@ public void initialize() {}
* @return An instance of the appropriate CopyFilter
*/
public static CopyFilter getCopyFilter(Configuration conf) {
+ String filtersClassName =
conf.get(DistCpConstants.CONF_LABEL_FILTERS_CLASS);
Review comment:
well, try with getClassByName().
Key point: you shouldn't be trying to reimplement a class loading through
configurations. There is a lot of stable coat there and it even includes
caching as well as the error handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
