[
https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976089#comment-16976089
]
David Mollitor commented on HADOOP-16716:
-----------------------------------------
[[email protected]] Thank you for the feedback.
I understand what you're saying about the ability to exclude the dependency.
In fact, what lead me to create this JIRA is that I noticed it was being
explicitly excluded in a project I was working on. I was thinking to myself
"why would this 'common' library ship a binding?" and "how would anyone know to
manually exclude this?" and "why does every project need to know to do this?"
I would wager that including this dependency ends up adding multiple bindings
to the classpath for upstream projects and causes a lot of warnings and
confusion. The entire point of SLF4J is that the bindings are pluggable. I
think it's much cleaner to have the upstream projects produce a warning that no
logger exists. This forces the user to make a decision about which logging
framework they want to use, if by some chance they don't already have a logger
included.
If this was for the HDFS NameNode, HDFS DataNode, YARN services, etc. I get it.
That is appropriate to include a logging framework. But it's not so clear to
me that a utility package called 'commons' would automatically introduce a
logging framework.
> slf4j-log4j12 Should Not Be Included as Dependency
> --------------------------------------------------
>
> Key: HADOOP-16716
> URL: https://issues.apache.org/jira/browse/HADOOP-16716
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.2
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
> The project should be using 'slf4j-api' to log to the SLF4J framwork, but the
> end-project, the project that includes hadoop-commons should be specifying
> the specific binding to use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
