steveloughran commented on issue #1711: HADOOP-16455. ABFS: Implement FileSystem.access() method. URL: https://github.com/apache/hadoop/pull/1711#issuecomment-555452054 Checkstyle ``` ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:22:import java.io.FileNotFoundException;:8: Unused import - java.io.FileNotFoundException. [UnusedImports] ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:94:import org.apache.hadoop.security.AccessControlException;:8: Unused import - org.apache.hadoop.security.AccessControlException. [UnusedImports] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java:219: public void testFsActionREAD_EXECUTE() throws Exception {:15: Name 'testFsActionREAD_EXECUTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java:235: public void testFsActionWRITE_EXECUTE() throws Exception {:15: Name 'testFsActionWRITE_EXECUTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodN ``` I'm not worried about those test name mismatches as they make sense and they are consistent with the rest. Unused imports should be removed. Other than that: it's ready to go in!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
