steveloughran commented on a change in pull request #1721: HADOOP-16709.
Consider having the ability to turn off TTL in S3Guard …
URL: https://github.com/apache/hadoop/pull/1721#discussion_r348623825
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3GuardOutOfBandOperations.java
##########
@@ -549,10 +566,16 @@ public void deleteAfterTombstoneExpiryOobCreate() throws
Exception {
guardedFs.delete(filePath, true);
// FILE MUST NOT EXIST IN RAW
- intercept(FileNotFoundException.class, filePath.toString(),
- "This file should throw FNFE when reading through "
- + "the raw fs, and the guarded fs deleted the file.",
- () -> rawFS.getFileStatus(filePath));
+ // If authoritative, the file status can be retrieved
Review comment:
now I'm confused. shouldn't deletion through a guarded FS remove it from raw
too? Or is it because the tombstone is in the auth dir that we don't bother to
pass down the delete?
If that's the case -which I think it is- can you make that clear in the
comments. It won't be obvious to anyone when we come back to this code in 2020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
