steveloughran commented on a change in pull request #1646: HADOOP-15430. hadoop
fs -mkdir -p path-ending-with-slash/ fails with s3guard
URL: https://github.com/apache/hadoop/pull/1646#discussion_r348628463
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/PathMetadataDynamoDBTranslation.java
##########
@@ -318,8 +318,20 @@ public static String pathToParentKey(Path path) {
static PrimaryKey pathToKey(Path path) {
Preconditions.checkArgument(!path.isRoot(),
"Root path is not mapped to any PrimaryKey");
- return new PrimaryKey(PARENT, pathToParentKey(path.getParent()), CHILD,
- path.getName());
+ String childName = path.getName();
+ PrimaryKey key = new PrimaryKey(PARENT,
+ pathToParentKey(path.getParent()), CHILD,
+ childName);
+ for (KeyAttribute attr : key.getComponents()) {
+ String name = attr.getName();
+ Object v = attr.getValue();
+ Preconditions.checkNotNull(v,
Review comment:
should move to Objects.notNull()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
