steveloughran commented on a change in pull request #1691: HADOOP-16424.
S3Guard fsck: Check internal consistency of the MetadataStore
URL: https://github.com/apache/hadoop/pull/1691#discussion_r349169328
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolDynamoDB.java
##########
@@ -324,4 +324,20 @@ public void testCLIFsckFailInitializeFs() throws
Exception {
() -> run(S3GuardTool.Fsck.NAME, "-check",
"s3a://this-bucket-does-not-exist-" + UUID.randomUUID()));
}
+
+ @Test
+ public void testCLIFsckDDbInternalWrongS3APath() throws Exception {
+ intercept(FileNotFoundException.class, "wrong path",
+ () -> run(S3GuardTool.Fsck.NAME, "-"+Fsck.DDB_MS_CONSISTENCY_FLAG,
+ "s3a://" + getFileSystem().getBucket() + "/" + UUID.randomUUID()));
+ }
+
+ @Test
+ public void testCLIFsckDDbInternalParam() throws Exception {
+ final int result = run(S3GuardTool.Fsck.NAME,
"-"+Fsck.DDB_MS_CONSISTENCY_FLAG,
+ "s3a://" + getFileSystem().getBucket());
+ LOG.info("This test serves the purpose to run fsck with the correct " +
Review comment:
move the first two lines of the log up into a describe() statement; if
something fails it would be good to have it in the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
