sapant-msft commented on a change in pull request #1708: HADOOP-16696: Always
read ahead config, to use read ahead even for non sequential reads.
URL: https://github.com/apache/hadoop/pull/1708#discussion_r349291105
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -446,9 +446,7 @@ public AbfsInputStream openFileForRead(final Path path,
final FileSystem.Statist
// Add statistics for InputStream
return new AbfsInputStream(client, statistics,
- AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
contentLength,
- abfsConfiguration.getReadBufferSize(),
abfsConfiguration.getReadAheadQueueDepth(),
- abfsConfiguration.getTolerateOobAppends(), eTag);
+ AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
contentLength, eTag, abfsConfiguration);
Review comment:
The number of options we are passing to the Stream has increased to 4,
causing Hadoop check style related issues (total arguments > 8). Also,
increasing the number of arguments doesn't feel like a scalable approach, in my
opinion. I agree, passing the whole abfsConfig object isn't very elegant
either. How would you feel about a new abfsInputStreamConfig structure (class),
to be used for passing stream related config options?
Thanks,
Saurabh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
