snvijaya commented on a change in pull request #1712: HADOOP-16699: Adding
verbose TRACE logging
URL: https://github.com/apache/hadoop/pull/1712#discussion_r349550519
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -143,8 +143,12 @@ public AzureBlobFileSystemStore(URI uri, boolean
isSecureScheme, Configuration c
} catch (IllegalAccessException exception) {
throw new FileSystemOperationUnhandledException(exception);
}
+
+ LOG.trace("AbfsConfiguration init complete");
+
this.userGroupInformation = UserGroupInformation.getCurrentUser();
this.userName = userGroupInformation.getShortUserName();
+ LOG.trace("UGI init complete");
Review comment:
Agree on the multiple logging, but a recent debugging session with an
internal client revealed that there could be multiple scenarios which could
look like a hung state in ABFSDriver initialization. The initial debugging
culprits included SSLDelegationContext instance initialization and UGI init
hitting a system error and failing to return the control back.
The actual cause of the issue turned out to be a hang in the initialization
of the custom token provider used in the user scenario.
As a precaution adding a log line whenever the control goes out of the ABFS
driver code, (most of the additional logging is in the initialize flow alone).
Also as it is too verbose, adding as TRACE logs. Please let me know if you
still feel that log line redundancy is high.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
