virajith commented on a change in pull request #452: HADOOP-16005: Add XAttr support to WASB and ABFS URL: https://github.com/apache/hadoop/pull/452#discussion_r352262757
########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java ########## @@ -123,7 +123,7 @@ private String primaryUserGroup; private static final String DATE_TIME_PATTERN = "E, dd MMM yyyy HH:mm:ss z"; private static final String TOKEN_DATE_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSSSSSS'Z'"; - private static final String XMS_PROPERTIES_ENCODING = "ISO-8859-1"; + static final String XMS_PROPERTIES_ENCODING = "ISO-8859-1"; Review comment: Let's keep this private. This information doesn't need to be exposed to the callers. Add helper methods to this class to encode/decode strings from AzureBlobFileSystem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
