c-w commented on a change in pull request #452: HADOOP-16005: Add XAttr support
to WASB and ABFS
URL: https://github.com/apache/hadoop/pull/452#discussion_r352311385
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
##########
@@ -3549,6 +3550,90 @@ public void setOwner(Path p, String username, String
groupname)
}
}
+ /**
+ * Set the value of an attribute for a path.
+ *
+ * @param path The path on which to set the attribute
+ * @param xAttrName The attribute to set
+ * @param value The byte value of the attribute to set (encoded in utf-8)
+ * @param flag The mode in which to set the attribute
+ * @throws IOException If there was an issue setting the attribute on Azure
+ */
+ @Override
+ public void setXAttr(Path path, String xAttrName, byte[] value,
EnumSet<XAttrSetFlag> flag) throws IOException {
Review comment:
I removed some more newlines in 6ecbdc0. I'm finding it a bit difficult to
discern what style to follow since the file seems to include multiple styles
for newlines (e.g. my original implementation was close to `setOwner` in
indentation style). If you have any additional feedback on-top of what is
implemented now, I'd appreciate more concrete pointers on style/formatting.
Thanks in advance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
