goiri commented on a change in pull request #1737: HDFS-14522. Allow compact
property description in xml in httpfs.
URL: https://github.com/apache/hadoop/pull/1737#discussion_r355081969
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestConfigurationUtils.java
##########
@@ -44,11 +44,12 @@ public void constructors() throws Exception {
}
- @Test(expected = IOException.class)
- public void constructorsFail3() throws Exception {
- InputStream is = new
ByteArrayInputStream("<xonfiguration></xonfiguration>".getBytes());
+ @Test
+ public void constructors3() throws Exception {
+ InputStream is = new ByteArrayInputStream("<xonfiguration><property
name=\"key1\" value=\"val1\"/></xonfiguration>".getBytes());
Configuration conf = new Configuration(false);
ConfigurationUtils.load(conf, is);
+ assertEquals(conf.get("key1"), "val1");
Review comment:
Reverse (expected first)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
