goiri commented on a change in pull request #1745: HDFS-15040. RBF: Secured
Router should not run when SecretManager is not running.
URL: https://github.com/apache/hadoop/pull/1745#discussion_r355712355
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/security/RouterSecurityManager.java
##########
@@ -58,7 +58,8 @@ public RouterSecurityManager(Configuration conf) throws
IOException {
AuthenticationMethod.KERBEROS;
if (authMethodConfigured.equals(authMethodToInit)) {
this.dtSecretManager = FederationUtil.newSecretManager(conf);
- if (this.dtSecretManager == null) {
+ if (this.dtSecretManager == null
+ || this.dtSecretManager.isRunning() == false) {
Review comment:
I guess we should do !this.dtSecretManager.isRunning().
This may also fit in a single line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
