steveloughran commented on a change in pull request #1752: HADOOP-16732.
S3Guard to support encrypted DynamoDB table
URL: https://github.com/apache/hadoop/pull/1752#discussion_r356710084
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStoreTableManager.java
##########
@@ -322,6 +326,24 @@ private void createTable(ProvisionedThroughput capacity)
throws IOException {
putVersionMarkerItemToTable();
}
+ /**
+ * Get DynamoDB table server side encryption (SSE) settings from
configuration.
+ */
+ private SSESpecification getSseSpecFromConfig() {
+ final SSESpecification sseSpecification = new SSESpecification();
+ sseSpecification.setEnabled(conf.getBoolean(S3GUARD_DDB_TABLE_SSE_ENABLED,
false));
+ String cmk = conf.get(S3GUARD_DDB_TABLE_SSE_CMK);
Review comment:
1. we may want to use getPassword here, probably via s3autils
2. this is just on table creation, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
