liusheng commented on a change in pull request #1771: YARN-10041. Create tmp
socket file under /tmp for CSI tests
URL: https://github.com/apache/hadoop/pull/1771#discussion_r360745127
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/src/test/java/org/apache/hadoop/yarn/csi/client/TestCsiClient.java
##########
@@ -36,23 +34,24 @@
*/
public class TestCsiClient {
- private static File testRoot = null;
+ private static File socketFile = null;
private static String domainSocket = null;
private static FakeCsiDriver driver = null;
@BeforeClass
public static void setUp() throws IOException {
- testRoot = GenericTestUtils.getTestDir("csi-test");
- File socketPath = new File(testRoot, "csi.sock");
- FileUtils.forceMkdirParent(socketPath);
- domainSocket = "unix://" + socketPath.getAbsolutePath();
+ socketFile = new File("/tmp", "yarn-csi-test.sock");
+ domainSocket = "unix://" + socketFile.getAbsolutePath();
driver = new FakeCsiDriver(domainSocket);
}
@AfterClass
public static void tearDown() throws IOException {
- if (testRoot != null) {
- FileUtils.deleteDirectory(testRoot);
+ if (socketFile != null && socketFile.exists()) {
+ if (!socketFile.delete()) {
+ String message = "Unable to delete file " + socketFile + ".";
+ throw new IOException(message);
+ }
Review comment:
Hi @ayushtkn,
Thanks for your review, here I wanted to keep the logical as before(the
FileUtils.deleteDirectory method) :) done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
