steveloughran commented on a change in pull request #1404: HDFS-13660 Copy file
till the source file length during distcp
URL: https://github.com/apache/hadoop/pull/1404#discussion_r363390684
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/util/TestDistCpUtils.java
##########
@@ -1248,28 +1245,24 @@ public void testCompareFileLengthsAndChecksums()
throws IOException {
replFactor, srcSeed);
DFSTestUtil.createFile(fs, dstWithChecksum1, 1024,
replFactor, srcSeed);
- DistCpUtils.compareFileLengthsAndChecksums(fs, srcWithChecksum1,
- null, fs, dstWithChecksum1, false);
- DistCpUtils.compareFileLengthsAndChecksums(fs, srcWithChecksum1,
+ DistCpUtils.compareFileLengthsAndChecksums(1024, fs, srcWithChecksum1,
Review comment:
howe about we factor out all these 1024s into a single variable, including
the one on L1246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
