bgaborg commented on a change in pull request #1752: HADOOP-16732. S3Guard to
support encrypted DynamoDB table
URL: https://github.com/apache/hadoop/pull/1752#discussion_r364817145
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
##########
@@ -1108,6 +1112,25 @@ private Table verifyTableInitialized(String tableName,
DynamoDB dynamoDB) {
return table;
}
+ /**
+ * Verify the table is created with correct server side encryption (SSE).
+ */
+ private void verifyTableSse(Configuration conf, TableDescription td) {
+ SSEDescription sseDescription = td.getSSEDescription();
+ if (conf.getBoolean(S3GUARD_DDB_TABLE_SSE_ENABLED, false)) {
Review comment:
```S3GUARD_DDB_TABLE_SSE_ENABLED``` should be true here, shouldn't it?
```assertEquals("ENABLED", sseDescription.getStatus());``` this will be only
satisfied if the SSE is enabled?
Please correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
