goiri commented on a change in pull request #1800: HDFS-15100. RBF: Print
stacktrace when DFSRouter fails to fetch/parse JMX output from NameNode.
URL: https://github.com/apache/hadoop/pull/1800#discussion_r364877454
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederationUtil.java
##########
@@ -98,13 +98,10 @@ public static JSONArray getJmx(String beanQuery, String
webAddress,
JSONObject json = new JSONObject(jmxOutput);
ret = json.getJSONArray("beans");
} catch (IOException e) {
- LOG.error("Cannot read JMX bean {} from server {}: {}",
- beanQuery, webAddress, e.getMessage());
- } catch (JSONException e) {
- LOG.error("Cannot parse JMX output for {} from server {}: {}",
- beanQuery, webAddress, e.getMessage());
+ LOG.error("Cannot read JMX bean {} from server {}: ",
+ beanQuery, webAddress, e);
} catch (Exception e) {
- LOG.error("Cannot parse JMX output for {} from server {}: {}",
Review comment:
I guess this is the one we need to capture.
Let's remove the last ":" and leave it as:
LOG.error("Cannot parse JMX output for {} from server {}",
beanQuery, webAddress, e);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
