[
https://issues.apache.org/jira/browse/HADOOP-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014910#comment-17014910
]
Akira Ajisaka commented on HADOOP-16753:
----------------------------------------
Thank you [~risyomei] for your patch. The patch mostly looks good to me.
Would you add the following check before checking in DFSHAAdmin?
{code}
if (!cmd.startsWith("-")) {
errOut.println("Bad command '" + cmd + "': expected command starting with
'-'");
printUsage(errOut);
return -1;
}
{code}
In addition, it would be better to create a function for checking the arguments
in HAAdmin and call the function from DFSHAAdmin to avoid writing the same code
twice.
> Refactor HAAdmin
> ----------------
>
> Key: HADOOP-16753
> URL: https://issues.apache.org/jira/browse/HADOOP-16753
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Akira Ajisaka
> Assignee: Xieming Li
> Priority: Major
> Attachments: HADOOP-16753.001.patch, HADOOP-16753.002.patch,
> HADOOP-16753.003.patch
>
>
> https://issues.apache.org/jira/browse/YARN-9985?focusedCommentId=16991414&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16991414
> We should move HDFS-specific haadmin options from HAAdmin to DFSHAAdmin to
> remove unnecessary if-else statements from RMAdmin command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
