vinayakumarb commented on a change in pull request #1635: HADOOP-16596.
[pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency
URL: https://github.com/apache/hadoop/pull/1635#discussion_r368509854
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
##########
@@ -61,11 +67,22 @@
<artifactId>protobuf-java</artifactId>
</dependency>
+ <dependency>
Review comment:
Explicit addition is to support different version of hadoop-common in
timelineserver. hadoop-common used in timelineserver may not have this
dependency, yarn-api will need it. So explicit dependency is required (followed
existing protobuf-java). As said above, to avoid enforce check failure due to
SNAPSHOT version resolution, excluded this from hadoop-common above.
After this change, timelineserver tests started passing in both hbase1 and
hbase2 profiles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
