vinayakumarb commented on issue #1635: HADOOP-16596. [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency URL: https://github.com/apache/hadoop/pull/1635#issuecomment-576247014 > Big diff -but needs to go in everywhere. > > 1. Its unfortunate it mixes org.apache import with others, but we had the same problem with the SLF4J update -we just have to accept it. > 2. should we have the protobuf version in the imports? A new upgrade will force a complete roll. What about "protobuf_current"? > Yes, its a very good point, Thanks. I added based on the discussion thread input, but didn't think about upgrade. Having version in package name will create more problems than ease of use during upgrade. Whatever package name we use here, same package name should be used inside shaded protobuf artifact. So in that case all versions of shaded artifact need to have "protobuf_current" itself. Instead 1. how about just changing to "protobuf3" to support protobuf 3.x release line, and have "protobuf4" for 4.x in future? This can support co-existence of both protobuf 3.x and protobuf 4.x shaded libs if any module requires during transition. or 2. Just "protobuf" to have minimal change in upgrade to any version (excluding the compilation incompatibilities if any introduced) No co-existence can be supported for future versions. Anyway to change this, first need to change in hadoop-thirdparty module.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
