ayushtkn commented on a change in pull request #1819: HDFS-14989. Add a 'swapBlockList' operation to Namenode. URL: https://github.com/apache/hadoop/pull/1819#discussion_r371354584
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSwapBlockList.java ########## @@ -0,0 +1,257 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs.server.namenode; + +import static org.junit.Assert.assertEquals; + +import java.io.FileNotFoundException; +import java.io.IOException; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hdfs.DFSConfigKeys; +import org.apache.hadoop.hdfs.DFSTestUtil; +import org.apache.hadoop.hdfs.DistributedFileSystem; +import org.apache.hadoop.hdfs.MiniDFSCluster; +import org.apache.hadoop.hdfs.server.blockmanagement.BlockInfo; +import org.apache.hadoop.hdfs.server.namenode.INodeFile.HeaderFormat; +import org.apache.hadoop.hdfs.server.namenode.snapshot.SnapshotTestHelper; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +/** + * Test SwapBlockListOp working. + */ +public class TestSwapBlockList { + + private static final short REPLICATION = 3; + + private static final long SEED = 0; + private final Path rootDir = new Path("/" + getClass().getSimpleName()); + + private final Path subDir1 = new Path(rootDir, "dir1"); + private final Path file1 = new Path(subDir1, "file1"); + private final Path file2 = new Path(subDir1, "file2"); + + private final Path subDir11 = new Path(subDir1, "dir11"); + private final Path file3 = new Path(subDir11, "file3"); + + private final Path subDir2 = new Path(rootDir, "dir2"); + private final Path file4 = new Path(subDir2, "file4"); + + private Configuration conf; + private MiniDFSCluster cluster; + private FSNamesystem fsn; + private FSDirectory fsdir; + + private DistributedFileSystem hdfs; + + @Before + public void setUp() throws Exception { + conf = new Configuration(); + conf.setInt(DFSConfigKeys.DFS_NAMENODE_MAX_XATTRS_PER_INODE_KEY, 2); + cluster = new MiniDFSCluster.Builder(conf) + .numDataNodes(REPLICATION) + .build(); + cluster.waitActive(); + + fsn = cluster.getNamesystem(); + fsdir = fsn.getFSDirectory(); + + hdfs = cluster.getFileSystem(); + + hdfs.mkdirs(subDir2); + + DFSTestUtil.createFile(hdfs, file1, 1024, REPLICATION, SEED); + DFSTestUtil.createFile(hdfs, file2, 1024, REPLICATION, SEED); + DFSTestUtil.createFile(hdfs, file3, 1024, REPLICATION, SEED); + DFSTestUtil.createFile(hdfs, file4, 1024, REPLICATION, SEED); + + } + + @After + public void tearDown() throws Exception { + if (cluster != null) { + cluster.shutdown(); + } + } + + @Test + public void testInputValidation() throws Exception { + + // Source file not found. + try { + fsn.swapBlockList("/TestSwapBlockList/dir1/fileXYZ", + "/TestSwapBlockList/dir1/dir11/file3", 0L); + Assert.fail(); + } catch (IOException ioEx) { + Assert.assertTrue(ioEx instanceof FileNotFoundException); + Assert.assertTrue( + ioEx.getMessage().contains("/TestSwapBlockList/dir1/fileXYZ")); + } Review comment: For the validations can use LambdaTestUtils, Like this ` LambdaTestUtils.intercept(FileNotFoundException.class, "/TestSwapBlockList/dir1/fileXYZ", () -> fsn .swapBlockList("/TestSwapBlockList/dir1/fileXYZ", "/TestSwapBlockList/dir1/dir11/file3", 0L));` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
