steveloughran commented on issue #1823: HADOOP-16794 S3 Encryption key is not getting set properly during put operation. URL: https://github.com/apache/hadoop/pull/1823#issuecomment-579837188 How to test? What are we trying to do? Our goal should be * the final file is encrypted Can you do a test case which replicates the problem, e.g. * writes a file with SSE-KMS/SSE-S3 (ignore SSE-C) * with an FS instance which doesn't have any encryption settings, copy that file (i.e. rename it) * using getObjectMetadata, look at its encryption settings to verify it is in encrypted We also have to handle * unencrypted file in S3 * renamed with an FS client which has SSE-S3/SSE-KMS set (and here, SSE-C) * final file MUST be encrypted with the given setting I still don't understand what's going wrong here though -we are trying to copy all the relevant keys Maybe we should be ignoring all of them and only explicitly setting those of our current instance. In which case: all encryption keys should be droped. How to test? What are we trying to do? Our goal should be * the final file is encrypted Can you do a test case which replicates the problem, e.g. * writes a file with SSE-KMS/SSE-S3 (ignore SSE-C) * with an FS instance which doesn't have any encryption settings, copy that file (i.e. rename it) * using getObjectMetadata, look at its encryption settings to verify it is in encrypted We also have to handle * unencrypted file in S3 * renamed with an FS client which has SSE-S3/SSE-KMS set (and here, SSE-C) * final file MUST be encrypted with the given setting I still don't understand what's going wrong here though -we are trying to copy all the relevant keys Maybe we should be ignoring all of them and only explicitly setting those of our current instance. In which case: all encryption keys should be droped.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
