hadoop-yetus removed a comment on issue #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation URL: https://github.com/apache/hadoop/pull/1820#issuecomment-578998841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 2m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 1m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 25m 57s | trunk passed | | +1 :green_heart: | compile | 22m 38s | trunk passed | | +1 :green_heart: | checkstyle | 3m 32s | trunk passed | | +1 :green_heart: | mvnsite | 2m 40s | trunk passed | | +1 :green_heart: | shadedclient | 24m 1s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 29s | trunk passed | | +0 :ok: | spotbugs | 1m 20s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 58s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 46s | the patch passed | | +1 :green_heart: | compile | 18m 58s | the patch passed | | +1 :green_heart: | javac | 18m 58s | the patch passed | | -0 :warning: | checkstyle | 2m 52s | root: The patch generated 83 new + 16 unchanged - 18 fixed = 99 total (was 34) | | +1 :green_heart: | mvnsite | 2m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 13m 58s | patch has no errors when building and testing our client artifacts. | | -1 :x: | javadoc | 1m 26s | hadoop-common-project_hadoop-common generated 87 new + 1 unchanged - 0 fixed = 88 total (was 1) | | -1 :x: | findbugs | 2m 44s | hadoop-common-project/hadoop-common generated 29 new + 0 unchanged - 0 fixed = 29 total (was 0) | | -1 :x: | findbugs | 1m 31s | hadoop-tools/hadoop-aws generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0) | ||| _ Other Tests _ | | -1 :x: | unit | 9m 45s | hadoop-common in the patch failed. | | +1 :green_heart: | unit | 1m 36s | hadoop-aws in the patch passed. | | +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. | | | | 146m 33s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-common-project/hadoop-common | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 42] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 45] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 48] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 51] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 54] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 57] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 60] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 63] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 66] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 69] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 72] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 75] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 81] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 78] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 84] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 87] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 90] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 93] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 96] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 99] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 102] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 105] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 108] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 111] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 114] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 117] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 120] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 123] | | | Unread public/protected field:At FilesystemStatisticNames.java:[line 126] | | FindBugs | module:hadoop-tools/hadoop-aws | | | Dead store to ioStats in new org.apache.hadoop.fs.s3a.S3AInputStream(S3AReadOpContext, S3ObjectAttributes, AmazonS3) At S3AInputStream.java:new org.apache.hadoop.fs.s3a.S3AInputStream(S3AReadOpContext, S3ObjectAttributes, AmazonS3) At S3AInputStream.java:[line 172] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.policySetCount in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.inputPolicySet(int) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.inputPolicySet(int) At S3AInstrumentation.java:[line 785] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readExceptions in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readException() At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readException() At S3AInstrumentation.java:[line 727] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperationStarted(long, long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperationStarted(long, long) At S3AInstrumentation.java:[line 757] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readsIncomplete in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationCompleted(int, int) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationCompleted(int, int) At S3AInstrumentation.java:[line 767] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationStarted(long, long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationStarted(long, long) At S3AInstrumentation.java:[line 747] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.backwardSeekOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long) At S3AInstrumentation.java:[line 676] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long) At S3AInstrumentation.java:[line 675] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.forwardSeekOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long) At S3AInstrumentation.java:[line 688] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long) At S3AInstrumentation.java:[line 687] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.aborted in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:[line 715] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.closeOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:[line 713] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.closed in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean, long) At S3AInstrumentation.java:[line 718] | | | Increment of volatile field org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.openOperations in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamOpened() At S3AInstrumentation.java:in org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamOpened() At S3AInstrumentation.java:[line 700] | | Failed junit tests | hadoop.security.TestFixKerberosTicketOrder | | | hadoop.security.TestRaceWhenRelogin | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1820 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 2301d54d6308 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 7f40e66 | | Default Java | 1.8.0_232 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/diff-checkstyle-root.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/testReport/ | | Max. process+thread count | 1341 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
