goiri commented on a change in pull request #1825: HDFS-15151 Use TransmitFile 
for file to socket data transfer
URL: https://github.com/apache/hadoop/pull/1825#discussion_r373709478
 
 

 ##########
 File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
 ##########
 @@ -819,6 +849,12 @@ public static boolean access(String path, AccessRight 
desiredAccess)
         }
       }
     }
+
+    public static void setConf(Configuration conf) {
 
 Review comment:
   Should we name this a little bit more specific and not only setConf? 
initTransmitFileEnabledConf()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to