[
https://issues.apache.org/jira/browse/HADOOP-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031440#comment-17031440
]
Tsuyoshi Ozawa edited comment on HADOOP-16596 at 2/6/20 10:22 AM:
------------------------------------------------------------------
[~vinayakumarb]
Thanks for your patch! I am happy since this jira moves forward now.
The source of this problem is that Hadoop shares 'different jars with same
name' between client and server. The patch solves the problem correctly. This
work is awesome.
One problem I come up with is ease of upgrading protobufs. When we upgrade the
protobuf version still at the server side, we need to change all lines of code
including "protobuf_3_7" (import statements). This is a safer way, but this
makes protobuf upgrading messy. Can we discuss this problem later since the
current patch is valuable enough to be merged?
I would like to run tests with your patch locally, trying to check whether it
works correctly.
was (Author: ozawa):
[~vinayakumarb]
Thanks for your patch! I am happy since this jira moves forward now.
The source of this problem is that Hadoop shares 'different jars with same
name' between client and server. The patch solves the problem correctly. This
work is awesome.
One problem I come up with is ease of upgrading protobufs. When we upgrade the
protobuf version still at the server side, we need to change all lines of code
including "protobuf_3_7" (import statements). This is a safer way, but this
makes protobuf upgrading messy. Can we discuss this problem later since the
current patch is both valuable enough to be merged?
I would like to run tests with your patch locally, trying to check whether it
works correctly.
> [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency
> --------------------------------------------------------------------------
>
> Key: HADOOP-16596
> URL: https://issues.apache.org/jira/browse/HADOOP-16596
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Priority: Major
>
> Use the shaded protobuf classes from "hadoop-thirdparty" in hadoop codebase.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
