[ 
https://issues.apache.org/jira/browse/HADOOP-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032055#comment-17032055
 ] 

Tsuyoshi Ozawa commented on HADOOP-16596:
-----------------------------------------

> One problem I come up with is ease of upgrading protobufs. When we upgrade 
>the protobuf version still at the server side, we need to change all lines of 
>code including "protobuf_3_7" (import statements). This is a safer way, but 
>this makes protobuf upgrading messy. Can we discuss this problem later since 
>the current patch is valuable enough to be merged? 

 

Sorry, this point was wrong. Your latest patch has already addressed the 
problem. 

 

Build passes on my local. +1 from me.

> [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-16596
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16596
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Major
>
> Use the shaded protobuf classes from "hadoop-thirdparty" in hadoop codebase.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to