[
https://issues.apache.org/jira/browse/HADOOP-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
testfixer0 updated HADOOP-16847:
--------------------------------
Description:
The method `testNegativeGroupCaching` in `TestGroupsCaching` can fail if the
iteration order of HashSet changes. In detail, in line 331, the method
`assertEquals` compare `groups.getGroups(user)` with a ArrayList `myGroups` .
However, `groups.getGroups(user)` is related with `FakeGroupMapping`. The
variables `allGroups` and `blackList` are defined as HashSet in
`FakeGroupMapping`, and it can iterate in a different order.
This PR proposes to modify HashSet to LinkedHashSet for a deterministic order.
was:The method `testNegativeGroupCaching` can fail if the iteration order of
HashSet changes. So, this PR proposes to modify HashSet to LinkedHashSet for a
deterministic order
> Test can fail if HashSet iterates in a different order
> ------------------------------------------------------
>
> Key: HADOOP-16847
> URL: https://issues.apache.org/jira/browse/HADOOP-16847
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.2.1
> Reporter: testfixer0
> Priority: Minor
> Attachments: HADOOP-16847-000.patch, HADOOP-16847-000.patch
>
>
> The method `testNegativeGroupCaching` in `TestGroupsCaching` can fail if the
> iteration order of HashSet changes. In detail, in line 331, the method
> `assertEquals` compare `groups.getGroups(user)` with a ArrayList `myGroups` .
> However, `groups.getGroups(user)` is related with `FakeGroupMapping`. The
> variables `allGroups` and `blackList` are defined as HashSet in
> `FakeGroupMapping`, and it can iterate in a different order.
> This PR proposes to modify HashSet to LinkedHashSet for a deterministic order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
