bgaborg commented on a change in pull request #1826: HADOOP-16823. Manage S3
Throttling exclusively in S3A client.
URL: https://github.com/apache/hadoop/pull/1826#discussion_r377019280
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java
##########
@@ -56,7 +57,13 @@ public AmazonS3 createS3Client(URI name,
final String userAgentSuffix) throws IOException {
Configuration conf = getConf();
final ClientConfiguration awsConf = S3AUtils
- .createAwsConf(getConf(), bucket, Constants.AWS_SERVICE_IDENTIFIER_S3);
+ .createAwsConf(conf, bucket, Constants.AWS_SERVICE_IDENTIFIER_S3);
+
+ // throttling is explicitly disabled on the S3 client so that
+ // all failures are collected
+ awsConf.setUseThrottleRetries(
+ conf.getBoolean(EXPERIMENTAL_AWS_INTERNAL_THROTTLING, true));
Review comment:
I'd rather add a setting for it than to set it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
