steveloughran commented on issue #1847: HADOOP-16859: ABFS: Add unbuffer support to ABFS connector URL: https://github.com/apache/hadoop/pull/1847#issuecomment-585957324 just realised ... that contract test doesn't ever verify that the data read back on an unbuffer/resume actually matches what should be there at the given offset. I think you should cache the dataset and validate the reads, so that if the reconnect got confused, it would surface. Similarly, do we need tests for unbuffer followed by positioned readable reads?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
