steveloughran commented on issue #1847: HADOOP-16859: ABFS: Add unbuffer support to ABFS connector URL: https://github.com/apache/hadoop/pull/1847#issuecomment-586609340 ``` ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractUnbufferTest.java:36: protected Path file;:18: Variable 'file' must be private and have accessor methods. [VisibilityModifier] ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractUnbufferTest.java:129: protected void validateFileContents(FSDataInputStream stream) throws IOException {: Line is longer than 80 characters (found 84). [LineLength] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47: byte[] data = ContractTestUtils.dataset(16, 'a', 26);:45: '16' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47: byte[] data = ContractTestUtils.dataset(16, 'a', 26);:54: '26' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:49: 16, true);:13: '16' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:56: assertTrue("unexpected stream type " +:44: '+' should be on a new line. [OperatorWrap] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:81: assertEquals("S3AInputStream#read did not read the correct number of " +:76: '+' should be on a new line. [OperatorWrap] ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
