[ 
https://issues.apache.org/jira/browse/HADOOP-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038666#comment-17038666
 ] 

Hudson commented on HADOOP-15961:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17960 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17960/])
HADOOP-15961. S3A committers: make sure there's regular progress() (stevel: rev 
c77fc6971b5194c9dae184703caa87da271a85eb)
* (edit) 
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
* (edit) 
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java
* (edit) 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java
* (add) 
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ProgressCounter.java
* (edit) 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/staging/StagingCommitter.java


> S3A committers: make sure there's regular progress() calls
> ----------------------------------------------------------
>
>                 Key: HADOOP-15961
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15961
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Steve Loughran
>            Assignee: lqjacklee
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: HADOOP-15961-001.patch, HADOOP-15961-002.patch, 
> HADOOP-15961-003.patch
>
>
> MAPREDUCE-7164 highlights how inside job/task commit more context.progress() 
> callbacks are needed, just for HDFS.
> the S3A committers should be reviewed similarly.
> At a glance:
> StagingCommitter.commitTaskInternal() is at risk if a task write upload 
> enough data to the localfs that the upload takes longer than the timeout.
> it should call progress it every single file commits, or better: modify 
> {{uploadFileToPendingCommit}} to take a Progressable for progress callbacks 
> after every part upload.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to