sahilTakiar commented on issue #1847: HADOOP-16859: ABFS: Add unbuffer support to ABFS connector URL: https://github.com/apache/hadoop/pull/1847#issuecomment-588021038 Fixed all the checkstyle issues besides the following: ``` ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47: byte[] data = ContractTestUtils.dataset(16, 'a', 26);:45: '16' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47: byte[] data = ContractTestUtils.dataset(16, 'a', 26);:54: '26' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:49: 16, true);:13: '16' is a magic number. [MagicNumber] ``` It's complaining that the parameters to `ContractTestUtils.dataset` should be `static final int` but I'm not sure thats worth it, we don't do there with the other uses of `ContractTestUtils.dataset` anyway.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
