jojochuang commented on a change in pull request #1846: HADOOP-15566. Support
Opentracing
URL: https://github.com/apache/hadoop/pull/1846#discussion_r382865557
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
##########
@@ -698,11 +698,14 @@ public void run() {
LOG.debug("Thread interrupted", e);
}
one = dataQueue.getFirst(); // regular data packet
- SpanId[] parents = one.getTraceParents();
+ SpanContext[] parents = one.getTraceParents();
if (parents.length > 0) {
+ // The original code stored multiple parents in the DFSPacket,
and
+ // use them ALL here when creating a new Span. We only use the
+ // last one FOR NOW. Moreover, we don't activate the Span for
now.
scope = dfsClient.getTracer().
- newScope("dataStreamer", parents[0]);
- scope.getSpan().setParents(parents);
+ newScope("dataStreamer", parents[0], false);
+ //scope.getSpan().setParents(parents);
Review comment:
i need to check if the concept matches but io.opentracing.Tracer offers a
addReference() API to represent the casual relationship.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
