adamantal commented on a change in pull request #1852: YARN-10152. Fix findbugs 
warnings in hadoop-yarn-applications-mawo-core module
URL: https://github.com/apache/hadoop/pull/1852#discussion_r383173751
 
 

 ##########
 File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core/src/main/java/org/apache/hadoop/applications/mawo/server/worker/WorkerId.java
 ##########
 @@ -111,6 +111,9 @@ public final void setWorkerId(final String localworkerId) {
    * Implememt equals method for WorkerId.
    */
   public final boolean equals(final Object o) {
 
 Review comment:
   Can we also add `@Override` to the `toString()` method as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to