hadoop-yetus commented on issue #1857: HADOOP-16878. Copy command in FileUtil 
to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-590453321
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  25m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  20m 28s |  trunk passed  |
   | +1 :green_heart: |  compile  |  18m 35s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 13s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  24m 17s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 39s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m 45s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 39s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 14s |  the patch passed  |
   | -1 :x: |  compile  |  21m 32s |  root in the patch failed.  |
   | -1 :x: |  javac  |  21m 32s |  root in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m  0s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | -1 :x: |  shadedclient  |  18m 15s |  patch has errors when building and 
testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  1s |  the patch passed  |
   | -1 :x: |  findbugs  |   2m 21s |  hadoop-common-project/hadoop-common 
generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 32s |  hadoop-common in the patch passed. 
 |
   | +1 :green_heart: |  asflicense  |   0m 45s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 155m 32s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-common-project/hadoop-common |
   |  |  Call to java.nio.file.Path.equals(org.apache.hadoop.fs.Path) in 
org.apache.hadoop.fs.FileUtil.copy(File, FileSystem, Path, boolean, 
Configuration)  At FileUtil.java:FileSystem, Path, boolean, Configuration)  At 
FileUtil.java:[line 446] |
   |  |  Call to org.apache.hadoop.fs.Path.equals(java.nio.file.Path) in 
org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, File, boolean, 
Configuration)  At FileUtil.java:FileStatus, File, boolean, Configuration)  At 
FileUtil.java:[line 501] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1857 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux f8db1f8f05fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 7f8685f |
   | Default Java | 1.8.0_242 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/patch-compile-root.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/patch-compile-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/testReport/ |
   | Max. process+thread count | 2316 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to