steveloughran commented on a change in pull request #1823: HADOOP-16794 S3
Encryption keys not propagating correctly during copy operation
URL: https://github.com/apache/hadoop/pull/1823#discussion_r384727376
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -3394,6 +3396,42 @@ private CopyResult copyFile(String srcKey, String
dstKey, long size,
});
}
+ /**
Review comment:
1. can you move down to where setOptionalCopyObjectRequestParameters() was
before; it will make it easier to cherry pick.
2. Restore the original name, with new args (and javadoc). Same reason -and
because we may want add more options in future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
