karthikhw commented on a change in pull request #1870: HDFS-15201 SnapshotCounter hits MaxSnapshotID limit URL: https://github.com/apache/hadoop/pull/1870#discussion_r386677308
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java ########## @@ -96,7 +96,7 @@ private final boolean snapshotDiffAllowSnapRootDescendant; private final AtomicInteger numSnapshots = new AtomicInteger(); - private static final int SNAPSHOT_ID_BIT_WIDTH = 24; + private static final int SNAPSHOT_ID_BIT_WIDTH = 31; Review comment: Sure @arp7 I will set to 28 then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org