hadoop-yetus commented on issue #1820: HADOOP-16830. Add public IOStatistics 
API + S3A implementation
URL: https://github.com/apache/hadoop/pull/1820#issuecomment-593973947
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  7s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
12 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 52s |  trunk passed  |
   | +1 :green_heart: |  compile  |  17m 52s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 51s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  7s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 35s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   1m  7s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 13s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 23s |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |  17m 17s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   2m 51s |  root: The patch generated 52 new 
+ 98 unchanged - 19 fixed = 150 total (was 117)  |
   | +1 :green_heart: |  mvnsite  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |  15m 41s |  patch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  the patch passed  |
   | -1 :x: |  findbugs  |   1m 17s |  hadoop-tools/hadoop-aws generated 13 new 
+ 0 unchanged - 0 fixed = 13 total (was 0)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   9m 40s |  hadoop-common in the patch passed.  |
   | -1 :x: |  unit  |   1m 33s |  hadoop-aws in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 47s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 129m 50s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-tools/hadoop-aws |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.policySetCount
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.inputPolicySet(int)
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.inputPolicySet(int)
  At S3AInstrumentation.java:[line 818] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readExceptions
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readException()
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readException()
  At S3AInstrumentation.java:[line 755] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readFullyOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readFullyOperationStarted(long,
 long)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readFullyOperationStarted(long,
 long)  At S3AInstrumentation.java:[line 788] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readsIncomplete
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readOperationCompleted(int,
 int)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readOperationCompleted(int,
 int)  At S3AInstrumentation.java:[line 799] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readOperationStarted(long,
 long)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.readOperationStarted(long,
 long)  At S3AInstrumentation.java:[line 777] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.backwardSeekOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekBackwards(long)
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekBackwards(long)
  At S3AInstrumentation.java:[line 700] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekBackwards(long)
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekBackwards(long)
  At S3AInstrumentation.java:[line 699] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.forwardSeekOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekForwards(long)
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekForwards(long)
  At S3AInstrumentation.java:[line 713] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekForwards(long)
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.seekForwards(long)
  At S3AInstrumentation.java:[line 712] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.aborted 
in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:[line 742] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.closeOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:[line 740] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.closed in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamClose(boolean,
 long)  At S3AInstrumentation.java:[line 745] |
   |  |  Increment of volatile field 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.openOperations
 in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamOpened()
  At S3AInstrumentation.java:in 
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl.streamOpened()
  At S3AInstrumentation.java:[line 726] |
   | Failed junit tests | hadoop.fs.shell.TestCopy |
   |   | hadoop.fs.s3a.TestS3AGetFileStatus |
   |   | hadoop.fs.s3a.TestS3AUnbuffer |
   |   | hadoop.fs.s3a.s3guard.TestObjectChangeDetectionAttributes |
   |   | hadoop.fs.s3a.TestListing |
   |   | hadoop.fs.s3a.TestS3ABlockOutputStream |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1820 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 62afb2be9326 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c0d0842 |
   | Default Java | 1.8.0_242 |
   | checkstyle | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/artifact/out/diff-checkstyle-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/testReport/ |
   | Max. process+thread count | 1363 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws 
U: . |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1820/11/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to