steveloughran commented on a change in pull request #1790: [HADOOP-16818] ABFS:
Combine append+flush calls for blockblob & appendblob
URL: https://github.com/apache/hadoop/pull/1790#discussion_r387726574
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -404,18 +425,25 @@ public OutputStream createFile(final Path path, final
boolean overwrite, final F
umask.toString(),
isNamespaceEnabled);
- final AbfsRestOperation op =
client.createPath(AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
true, overwrite,
- isNamespaceEnabled ? getOctalNotation(permission) : null,
- isNamespaceEnabled ? getOctalNotation(umask) : null);
- perfInfo.registerResult(op.getResult()).registerSuccess(true);
+ boolean appendBlob = false;
+ if (isAppendBlobKey(path.toString())) {
+ appendBlob = true;
+ }
+
+ client.createPath(AbfsHttpConstants.FORWARD_SLASH +
getRelativePath(path), true, overwrite,
+ isNamespaceEnabled ? getOctalNotation(permission) : null,
+ isNamespaceEnabled ? getOctalNotation(umask) : null,
+ appendBlob);
return new AbfsOutputStream(
- client,
- AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
- 0,
- abfsConfiguration.getWriteBufferSize(),
- abfsConfiguration.isFlushEnabled(),
- abfsConfiguration.isOutputStreamFlushDisabled());
+ client,
+ AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
+ Long.valueOf(0),
Review comment:
nit: why not just 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
