aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune 
jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388717083
 
 

 ##########
 File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/DockerClientConfigHandler.java
 ##########
 @@ -103,7 +103,7 @@ public static Credentials 
readCredentialsFromConfigFile(Path configFile,
 
 
 Review comment:
   In L99-101:
   * ObjectMapper instance should be reused.
   * Two methods are deprecated.
   Should be fixed in a separate jira.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to