liuml07 commented on a change in pull request #1875: HADOOP-16794. S3A reverts
KMS encryption to the bucket's default KMS …
URL: https://github.com/apache/hadoop/pull/1875#discussion_r389232675
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java
##########
@@ -42,11 +46,24 @@
protected Configuration createConfiguration() {
Configuration conf = super.createConfiguration();
S3ATestUtils.disableFilesystemCaching(conf);
- conf.set(Constants.SERVER_SIDE_ENCRYPTION_ALGORITHM,
- getSSEAlgorithm().getMethod());
+ patchConfigurationEncryptionSettings(conf);
return conf;
}
+ /**
+ * This removes the encryption settings from the
Review comment:
I can reproduce the test failure. I ran the test with
`fs.s3a.bucket.BUCKETNAME.server-side-encryption.key` set in `auth-keys.xml`.
I set the S3 bucket default encryption policy as SSE-KMS, and that is not
changing the `ITestS3AEncryptionSSES3 ` test failure (as expected). Well, test
`ITestS3AEncryptionWithDefaultS3Settings` could pass then (again, as expected).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
