liuml07 commented on a change in pull request #533: HADOOP-14630 Contract
Tests to verify create, mkdirs and rename under a file is forbidden
URL: https://github.com/apache/hadoop/pull/533#discussion_r389831358
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java
##########
@@ -332,4 +323,117 @@ public void testCreateMakesParentDirs() throws Throwable
{
assertTrue("Grandparent directory does not appear to be a directory",
fs.getFileStatus(grandparent).isDirectory());
}
+
+ @Test
+ public void testCreateFileUnderFile() throws Throwable {
+ describe("Verify that it is forbidden to create file/file");
+ if (isSupported(CREATE_FILE_UNDER_FILE_ALLOWED)) {
+ // object store or some file systems: downgrade to a skip so that the
+ // failure is visible in test results
+ skip("This filesystem supports creating files under files");
+ }
+ Path grandparent = methodPath();
+ Path parent = new Path(grandparent, "parent");
+ expectCreateUnderFileFails(
+ "creating a file under a file",
+ grandparent,
+ parent);
+ }
+
+ @Test
+ public void testCreateUnderFileSubdir() throws Throwable {
+ describe("Verify that it is forbidden to create file/dir/file");
+ if (isSupported(CREATE_FILE_UNDER_FILE_ALLOWED)) {
+ // object store or some file systems: downgrade to a skip so that the
+ // failure is visible in test results
+ skip("This filesystem supports creating files under files");
+ }
+ Path grandparent = methodPath();
+ Path parent = new Path(grandparent, "parent");
+ Path child = new Path(parent, "child");
+ expectCreateUnderFileFails(
+ "creating a file under a subdirectory of a file",
+ grandparent,
+ child);
+ }
+
+
+ @Test
+ public void testMkdirUnderFile() throws Throwable {
+ describe("Verify that it is forbidden to create file/dir");
+ Path grandparent = methodPath();
+ Path parent = new Path(grandparent, "parent");
+ expectMkdirsUnderFileFails("mkdirs() under a file",
+ grandparent, parent);
+ }
+
+ @Test
+ public void testMkdirUnderFileSubdir() throws Throwable {
+ describe("Verify that it is forbidden to create file/dir/dir");
+ Path grandparent = methodPath();
+ Path parent = new Path(grandparent, "parent");
+ Path child = new Path(parent, "child");
+ expectMkdirsUnderFileFails("mkdirs() file/dir",
+ grandparent, child);
+
+ try {
Review comment:
Yes I think this test `testMkdirUnderFileSubdir` makes perfect sense. In
this test, I was assuming the whole `try-catch` clause is having the same logic
(except exception handling) as the call to `expectMkdirsUnderFileFails()` in
LoC 376 in this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
