goiri commented on a change in pull request #1889: HDFS-15215 The Timestamp for
longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#discussion_r391119110
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
##########
@@ -29,17 +29,19 @@
@InterfaceAudience.Private
@InterfaceStability.Unstable
public class FakeTimer extends Timer {
+ private long now;
private long nowNanos;
/** Constructs a FakeTimer with a non-zero value */
public FakeTimer() {
// Initialize with a non-trivial value.
+ now = 1577836800000L; // 2020-01-01 00:00:00,000+0000
Review comment:
Can we leave the old behavior as it was and add a method to change the
nowNanos so we only set it there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
